[Webkit-unassigned] [Bug 245321] Ran clang-tidy on JSC, WTF and bmalloc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=245321

--- Comment #10 from Nikolas Zimmermann <zimmermann at kde.org> ---
(In reply to Yusuke Suzuki from comment #9)
> (In reply to Mikhail R. Gadelha from comment #8)
> > (In reply to Yusuke Suzuki from comment #7)
> > > (In reply to Mikhail R. Gadelha from comment #6)
> > > > Hey Yusuke, I'll help Nikolas debugging the issue, please wait a couple of
> > > > days before reverting it.
> > > 
> > > It is not OK. The latest watchOS is build is already broken, which needs to
> > > be fixed ASAP.
> > 
> > I'll work on it.
> > 
> > Also, is there a log of the watchOS crash?
> 
> I'm seeing the changes in detail right now, and seeing a bit wrong changes
> in various places. For example, JSC::UnlinkedFunctionExecutable::m_features'
> initialization look missing. Unused `m_spillStateForJSGetterSetter` field is
> added in AccessGenerationState, etc.
> So you need to split the changes and we need careful review for each change.
> I'll revert it now.

Thanks Yusuke, I've aleady had a hard time splitting up the patch into more smaler pieces, to continue my bisect within the patch... :/

I agree it is easier to revert it, and reland smaller -- after the SIGILL is understood.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221006/3e77b461/attachment-0001.htm>