[Webkit-unassigned] [Bug 248407] New: Fix Typo in WebGLRenderingContextBase.h for "texParameter" helper function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 09:37:51 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=248407

            Bug ID: 248407
           Summary: Fix Typo in WebGLRenderingContextBase.h for
                    "texParameter" helper function
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: dino at apple.com, kbr at google.com, kkinnunen at apple.com

Hi Team,

While going through Blink commit, I found another typo, which we still have and it would be good to fix.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/01e308688d652724afbc976dd1dbf6a37d662603

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/1b6e6070bbb4454799b98ee84c5f0a72526b24f0/Source/WebCore/html/canvas/WebGLRenderingContextBase.h#LL1019

Here it is:

  -  void texParameter(GCGLenum target, GCGLenum pname, GCGLfloat parami, GCGLint paramf, bool isFloat);
  +  void texParameter(GCGLenum target, GCGLenum pname, GCGLfloat paramf, GCGLint parami, bool isFloat);

It is fixed in Chromium / Blink - checked via source.chromium.org, just wanted to raise bug before fixing this. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221128/005cc961/attachment-0001.htm>


More information about the webkit-unassigned mailing list