[Webkit-unassigned] [Bug 235792] css/css-fonts/animations/font-variation-settings-interpolation.html has failures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235792

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmad.saleem792 at gmail.com

--- Comment #7 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Antoine Quint from comment #6)
> The issue is that we're animating font-variation-settings values which are
> floats and using a very large progress value for blending that itself is
> represented as a double. The blending happens in this method:
> 
> static inline float blendFunc(float from, float to, const
> CSSPropertyBlendingContext& context)
> {
>     if (context.compositeOperation == CompositeOperation::Replace)
>         return narrowPrecisionToFloat(from + (to - from) * context.progress);
>     return narrowPrecisionToFloat(from + from + (to - from) *
> context.progress);
> }
> 
> If we returned a double here, we would retain the precision, but
> narrowPrecisionToFloat() leads to the Infinity value.

In the past, I tried to clamp narrowPrecisionToFloat in bug 245356 and it changed this test from infinity to value.

PR - https://github.com/WebKit/WebKit/pull/4580

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221124/3fbd6de2/attachment.htm>