[Webkit-unassigned] [Bug 248232] REGRESSION(2.39.1): gibberish text visible in blank placeholder tabs before first "real" page load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=248232

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |achristensen at apple.com

--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Hi Alex, I suspect 256488 at main "Ensure AddAllowedFirstPartyForCookies message is processed before ScheduleResourceLoad" is to blame. I think the problem is the const IPC::DataReference& htmlData contains unowned data and must not be used after the function call completes. It's assigned to loadParameters.data, which after your commit is now used inside a callback that executes after the data has already been freed. So we just need to make a copy somehow.

I hope other places do not have a similar problem. IPC::DataReference is really a WTF::span, which is equivalent to std::span, which is a non-owning reference, not a refcount-style reference like our WTF::Ref. The pretty name IPC::DataReference sure *seems* like it should be owned, but it's not. It's just too easy to mess up with C++. :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221122/cd58eb7f/attachment.htm>