[Webkit-unassigned] [Bug 107967] Deleting a button and typing text afterwards applies wrong styling to the typed text
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 17 12:22:41 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=107967
--- Comment #6 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
I tried to fix this bug in below PR:
Link - https://github.com/WebKit/WebKit/pull/5995
But after discussions with rniwa, I am going to close it and document approach here:
__________
1) Doing 1-1 Blink merge works and it compile but it is not desirable result because of Comment 03 as highlighted.
2) While trying to do it as per rniwa guidance in PR, we get following test failures:
editing/deleting/maintain-style-after-delete.html
editing/execCommand/underline-selection-containing-image.html, editing/style/5084241.html
editing/style/background-color-retained.html
editing/style/style-3681552-fix-002.html
____
1) maintain-style-after-delete.html - we lose font color and span of caret color and this behavior matches with Firefox Nightly 109.
Link - https://jsfiddle.net/3Lbw76a4/show
2) underline-selection-containing-image.html - we get new Console Error message "CONSOLE MESSAGE: TypeError: null is not an object (evaluating 'document.querySelector("U").textContent')" - losing styling as intended and get similar behavior to chrome in test case.
Link - https://jsfiddle.net/76n3rjf8/ (Look at console error of Chrome)
3) editing/style/5084241.html - We match with Firefox here and loss "Red" font color from the first line of text here.
4) background-color-retained.html - We match with Firefox here and loss "background" color from the text after deletion.
Link - https://jsfiddle.net/Lzx97c5u/
5) style-3681552-fix-002.html - We don't match any browser after this change and we loss italic styling of "xxx" and it can be interop issue. Although, Chrome does not have this test anymore based on search from source.chromium.org.
_______
These are findings based on PR and any failure into it.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221117/2b342047/attachment.htm>
More information about the webkit-unassigned
mailing list