[Webkit-unassigned] [Bug 248041] New: Style Fixes pushed smartly similar to missing headers
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 17 08:56:49 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=248041
Bug ID: 248041
Summary: Style Fixes pushed smartly similar to missing headers
Product: WebKit
Version: Safari Technology Preview
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
Assignee: webkit-unassigned at lists.webkit.org
Reporter: ahmad.saleem792 at gmail.com
Hi Team,
Another suggestion, right now "Style Script" run each commit and if there are some issue like not following code practices is something and it is stricter code quality control but at the same time it can be smarter:
Scenario - if there are only style issue because someone used if {...} (curly brackets) with just one argument while it compiles and passed all layout test, I think fixing the style and running all EWS layout suite again is pointless.
Smarter Approach - compile list of all PR pushed weekly with style issue (some common) and some script fix them in one go and do one PR automatically and merge them.
____
As for keeping the user informed about issue in the style, rather than using ❌ , it would be better to use ⚠️ as icon and post comment on "GitHub" and link to post explaining how Webkit smarter control can fix it automatically after the week and it is to optimise resources.
____
These for some common style issues would enable the contributor to push the patches without worrying that they have to run the EWS again now that they had made some 'style" error.
Please ignore if it might have some concerns or down the line complex issue.
Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221117/40366fc1/attachment.htm>
More information about the webkit-unassigned
mailing list