[Webkit-unassigned] [Bug 246852] [GTK] Crash on authentication dialog with GTK 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=246852

--- Comment #13 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to enometh from comment #12)
> Let me know if you want to remove the gtk4 section and just have a if
> !USE(GTK4) block.

Yes, do that.

> > Please remove all your personal comments, as they don't belong in the final version of the code.
> 
> Yes of course. Should I leave a comment here that says
> // focus is not a valid signal for a Dialog Window in gtk4. use move-focus
> instead
> or is it the commit message enough? I'd leave it in

The commit message is enough. No need to retain the comment. The fact that you've done something different in the USE(GTK4) block than in the !USE(GTK4) block is already enough documentation that the signal has changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221115/e170586c/attachment.htm>