[Webkit-unassigned] [Bug 246852] [GTK] Crash on authentication dialog with GTK 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 06:35:23 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=246852

--- Comment #11 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 463425
  --> https://bugs.webkit.org/attachment.cgi?id=463425
fix-gtk4-auth-dialog-crashes.-take-one.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463425&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1873
> +#if USE(GTK4)
> +static void webkitWebViewBaseMoveFocus(GtkWidget* widget, GtkDirectionType direction)
> +{
> +    WebKitWebViewBasePrivate* priv = WEBKIT_WEB_VIEW_BASE(widget)->priv;
> +    if (priv->dialog) {
> +        g_signal_emit_by_name(priv->dialog, "move-focus", direction);
> +    }
> +
> +    GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->move_focus(widget, direction);
> +}

Question for developers familiar with GTK: how bad is this? Somehow I suspect there is a better way than using g_signal_emit_by_name(), and yet this seems like it should work....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221115/b19448cc/attachment.htm>


More information about the webkit-unassigned mailing list