[Webkit-unassigned] [Bug 246852] [GTK] Crash on authentication dialog with GTK 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 15 06:25:21 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=246852

--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Here are the errors from the style bot:

ERROR: Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:69:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
ERROR: Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:192:  Declaration has space between type name and * in GtkWidget *tmplabel  [whitespace/declaration] [3]
ERROR: Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1890:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/UIProcess/API/gtk/WebKitWebViewDialog.cpp:127:  Should have a space between // and comment  [whitespace/comments] [4]

It won't check your commit message for you until you try to commit, at which point it will fail. Just try to make yours look like what everybody else does and you'll be fine. The title of the bug report is the first line, then a link to the bug on the next line, then a blank line, then "Reviewed by NOBODOY (OOPS!)", then a blank line, then describe your commit, then follow up with the yucky GNU changelog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221115/bd4d672e/attachment.htm>


More information about the webkit-unassigned mailing list