[Webkit-unassigned] [Bug 247918] New: Change ReplaceSelectionCommand::moveNodeOutOfAncestor() to avoid hitting assertion while trying replace selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247918

            Bug ID: 247918
           Summary: Change
                    ReplaceSelectionCommand::moveNodeOutOfAncestor() to
                    avoid hitting assertion while trying replace selection
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: wenson_hsieh at apple.com

Hi Team,

While going through Blink Commits, I came across crash fix in HTML Editing, which can also fix few assertion bugs in Webkit:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=153031&view=revision

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/b308d25de831f4b7d9c1d643fd166417ef4a5c5e/Source/WebCore/editing/ReplaceSelectionCommand.cpp#L837

Add:

if (!protectedAncestor->parentNode()->hasEditableStyle())

Just wanted to raise to fix it.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221114/02c28654/attachment.htm>