[Webkit-unassigned] [Bug 247751] Return after throwing an exception when ConvolerNode.buffer rate is wrong

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 03:55:19 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=247751

--- Comment #2 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Karl Dubost from comment #1)
> Ahmad,
> 
> it returns an exception currently
> https://github.com/WebKit/WebKit/blob/
> 06f9978e52a8408ed6c2c8296afb1e7449c2f1ee/Source/WebCore/Modules/webaudio/
> ConvolverNode.cpp#L120-L121
> 
> You can see it was modified here
> https://github.com/WebKit/WebKit/commit/
> 935f2c7e99aa9f6e03ca7e9449eed91235ceb865#diff-
> e1c0c01c871ffb6653371a1717b09d4f45b6153e6f1e783c8777a9e4a70b7a1dL127-L130
> 
> 
> And then before it was
> https://github.com/WebKit/WebKit/blame/
> c996d8b5e859f3dc0090d669eeed82a2370a2aa7/Source/WebCore/Modules/webaudio/
> ConvolverNode.cpp#L127-L130
> 
> with the return.
> 
> 
> my interpretation: the chromium code was just throwing the exception before
> instead of returning it. But I'm not an expert. 
> 
> What do you think?

If I understand Blink commit then they are adding return because they continued using wrong buffer rate even after throwing exception, while in Webkit code, if I look into from your links, it seems that we use to return earlier because didn't supported the feature by throwing "Not Supported" kind of error message and later when we added supported, we just had the "Exception" message now but we are not returning and continuing with wrong buffer rate but I can be wrong as well but this is my interpretation.
Do you anyone who might be familiar with this code to say whether we need to do anything like early return for this or do nothing because Webkit can handle wrong buffer rate smartly as it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221111/f15d24e5/attachment.htm>


More information about the webkit-unassigned mailing list