[Webkit-unassigned] [Bug 164999] text-overflow: ellipsis truncates the text incorrectly in RTL
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 9 10:47:18 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=164999
Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ahmad.saleem792 at gmail.com
--- Comment #13 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Blink Commit -
____
Remove this:
https://github.com/WebKit/WebKit/blob/762de66f4784b558929d769b76e810175347f9b4/Source/WebCore/rendering/TextBoxPainter.cpp#L741
Fix this:
https://github.com/WebKit/WebKit/blob/7fb461c6b698958bae8581ca2a7817f6f4d3772c/Source/WebCore/rendering/LegacyInlineTextBox.cpp#L265
https://github.com/WebKit/WebKit/blob/7fb461c6b698958bae8581ca2a7817f6f4d3772c/Source/WebCore/rendering/LegacyInlineTextBox.cpp#L282
Don't know where to add this:
+ // Where the text and its flow have opposite directions then our offset into the text given by |truncation| is at
+ // the start of the part that will be visible.
+ if (m_inlineTextBox.truncation() != cNoTruncation && m_inlineTextBox.getLineLayoutItem().containingBlock().style()->isLeftToRightDirection() != m_inlineTextBox.isLeftToRightDirection()) {
+ startOffset = m_inlineTextBox.truncation();
+ endOffset = textRun.length();
+ }
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221109/e9b59acb/attachment.htm>
More information about the webkit-unassigned
mailing list