[Webkit-unassigned] [Bug 247314] Code style does not match comments given in review related to newlines and preprocessor conditionals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 08:40:37 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=247314

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org,
                   |                            |darin at apple.com

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
I think this code is correct:

#if USE(UNIX_DOMAIN_SOCKETS)
    using Handle = UnixFileDescriptor;
#elif OS(WINDOWS)
    using Handle = Win32Handle;
#elif OS(DARWIN)
    using Handle = MachSendRight;
#endif

In this case, statements within if-elif is indented, so we don't need to insert a blank line to differentiate / distinguish if-elif-endif further.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221101/c6785c03/attachment.htm>


More information about the webkit-unassigned mailing list