[Webkit-unassigned] [Bug 247314] New: Code style does not match comments given in review related to newlines and preprocessor conditionals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247314

            Bug ID: 247314
           Summary: Code style does not match comments given in review
                    related to newlines and preprocessor conditionals
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kkinnunen at apple.com
                CC: cdumez at apple.com, rniwa at webkit.org,
                    webkit-bug-importer at group.apple.com

Code style does not match comments given in review related to newlines and preprocessor conditionals

C++ code snippet under review:

  #include "IPCTesterProxy.h"

  #if ENABLE(IPC_TESTING_API)
  namespace WebKit {

Was denied with comment

  > Also need a blank line between #if and namespace.

Define what is the rule to follow in this case and codify it somehow in the code style.


This is a currently non-deterministic in current reviews: some people might require, some allow and some deny.

This causes un-needed churn during review, wasting time in review as well as re-authoring, rebasing, re-submitting and re-waiting slow EWS results and patch landings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221101/89271285/attachment.htm>