[Webkit-unassigned] [Bug 241077] Include <sys/sysinfo.h> only on FreeBSD and Linux

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 30 04:12:58 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=241077

--- Comment #12 from Leonardo Taccari <iamleot+webkit-bugzilla at gmail.com> ---
(In reply to Fujii Hironori from comment #8)
> Comment on attachment 459840 [details]
> Include <sys/sysinfo.h> only on FreeBSD and Linux
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459840&action=review
> 
> > Source/bmalloc/bmalloc/AvailableMemory.cpp:-47
> > -#include <sys/sysinfo.h>
> 
> Unfortunately, sytle checker doesn't like this change.
> 
> > ERROR: Source/bmalloc/bmalloc/AvailableMemory.cpp:54:  "sys/sysinfo.h" already included at Source/bmalloc/bmalloc/AvailableMemory.cpp:50  [build/include] [4]
> 
> #if BOS(FREEBSD) || BOS(LINUX)
> #include <sys/sysinfo.h>
> #endif
> 
> This condition matches with the implementation of AvailableMemory.cpp.
> 
> You can style errors with Tools/Scripts/check-webkit-style before uploading.
> If you use `webkit-patch upload` or `git-webkit pr` scripts to upload your
> patch, it automatically run check-webkit-style.

Thanks, I have resubmitted it and I hope it's fine this time!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220530/a2858728/attachment.htm>


More information about the webkit-unassigned mailing list