[Webkit-unassigned] [Bug 240945] New: `git-webkit pr` requires uncommitted changes to do any work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240945

            Bug ID: 240945
           Summary: `git-webkit pr` requires uncommitted changes to do any
                    work
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Major
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kbr at google.com

`git-webkit pr` requires uncommitted changes in order to do any work. Otherwise, it reports:

No modified files

This single design decision breaks git workflows badly, and is a regression compared to "webkit-patch upload". In the past couple of days using the script, I've already forgotten multiple times to not commit my changes locally, both to my own branches when initiating a pull request, and to existing pull request branches under the eng/ namespace.

Please make the following improvements:

1) If on a user's local branch (not one which "git-webkit pr" created), and all changes have already been committed, create a new branch under the eng/ namespace and follow the current workflow to incorporate all commits relative to origin/main (or to the upstream branch - however the script currently works), produce the commit message from a template, and upload it.

2) If on one of the eng/ branches, and all changes have been committed, allow "git-webkit pr --amend" or just "git-webkit pr" to push the current set of commits to the already-open pull request.

Thanks in advance for implementing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220526/79520a2d/attachment-0001.htm>