[Webkit-unassigned] [Bug 240900] New: Default behavior of GitHub pre-commit hook interferes with development workflow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 22:33:16 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=240900

            Bug ID: 240900
           Summary: Default behavior of GitHub pre-commit hook interferes
                    with development workflow
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rego at igalia.com
            Blocks: 239082

Maybe this is just me, but when I work on a patch, I usually have a local branch where I do a lot of small commits.

For these commits I use simple "one liner" commit messages.

Once I have something useful for sending to review, then I squash these commits together, and write a proper commit message and the like.

The problem I see with the new GitHub workflow, is that every local commit, is running the pre-commit hook, and generating a very big commit messsage. I found a way to skip that with "git commit -m" but I wonder if this is the right default or not.

When I'm running "git-webkit upload" then I'd be happy to be asked to provide a good commit message and all that, but before that it seems like noise to my way of working.

WDYT?


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=239082
[Bug 239082] GitHub feedback umbrella
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220525/798cfb43/attachment.htm>


More information about the webkit-unassigned mailing list