[Webkit-unassigned] [Bug 240701] New: "No new tests (OOPS!)." is ending up in the middle of commit messages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240701

            Bug ID: 240701
           Summary: "No new tests (OOPS!)." is ending up in the middle of
                    commit messages
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com

The pre-filled commit message for https://github.com/WebKit/WebKit/pull/814 ended up like:

5dd145e

ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=240699
<rdar://92182174>

Reviewed by NOBODY (OOPS!).

Replace `status == U_ZERO_ERROR` tests with `U_SUCCESS(status)`.

* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::ErrorCallbackSetter::ErrorCallbackSetter):
(PAL::ErrorCallbackSetter::~ErrorCallbackSetter):
* Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:
(WebKit::SpoofChecker::checker):
No new tests (OOPS!).
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::createSearcher):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::~SearchBuffer):
(WebCore::SearchBuffer::search):

Note "No new tests (OOPS!)." in the middle which I totally missed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220520/095434ac/attachment-0001.htm>