[Webkit-unassigned] [Bug 239857] ITP data not deleted when cleared via WebsiteDataStore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=239857

--- Comment #18 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Kate Cheney from comment #17)
> My thought here was that any in-memory storage would be cleared after a
> session restart. If we restart and still see the cleared data appearing,
> then we know that domains are in the ITP database (either never were cleared
> or were re-inserted) and not just hanging around in memory somewhere. Might
> give us some additional info.

It persists across restarts.

> Looking for calls to
> ResourceLoadStatisticsDatabaseStore::insertObservedDomain might be useful
> here. That's how we enter new domains into the database. If we see that
> being called for domains previously deleted, we know that ITP is
> re-inserting some deleted domains.

Good guess. I see lots of calls to this ResourceLoadStatisticsDatabaseStore::insertObservedDomain when doing a clear (webkit_website_data_manager_clear()/ResourceLoadStatisticsDatabaseStore::clear) operation. If I just do individual removes (webkit_website_data_manager_remove()/ResourceLoadStatisticsDatabaseStore::removeDataForDomain), and then restart without doing a clear, then they do stay permanently removed. So we're dealing with theory (1) We explicitly add domains back to the ITP database after clearing (but not after removeDataForDomain).

Next step: I'll try to figure out why ResourceLoadStatisticsDatabaseStore::insertObservedDomain is being called.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220516/b1044e9b/attachment.htm>