[Webkit-unassigned] [Bug 240364] New: -Wunused-result in WebCoreSupport/WebContextMenuClient.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 17:39:43 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=240364

            Bug ID: 240364
           Summary: -Wunused-result in
                    WebCoreSupport/WebContextMenuClient.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: cdumez at apple.com, kkinnunen at apple.com

Looks like https://github.com/WebKit/WebKit/pull/499 "Annotate more String member functions with WARN_UNUSED_RETURN" uncovered a bug in WebContextMenuClient

[242/300] Building CXX object Source/WebKit/CMakeFiles/Web...ces/WebKit/unified-sources/UnifiedSource-54928a2b-34.cpp.o
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-34.cpp:3:
/home/mcatanzaro/Projects/WebKit/Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp: In member function ‘virtual void WebKit::WebContextMenuClient::searchWithGoogle(const WebCore::Frame*)’:
/home/mcatanzaro/Projects/WebKit/Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp:62:35: warning: ignoring return value of ‘WTF::String WTF::String::stripWhiteSpace() const’, declared with attribute ‘warn_unused_result’ [-Wunused-result]
   62 |     searchString.stripWhiteSpace();
      |                                   ^
In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/text/AtomString.h:27,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/text/StringHash.h:25,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/text/AtomStringTable.h:27,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/Threading.h:51,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/WeakPtr.h:31,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/text/TextStream.h:33,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/ObjectIdentifier.h:32,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/PrivateHeaders/WebCore/FrameIdentifier.h:28,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/PrivateHeaders/WebCore/FrameLoaderClient.h:32,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/PrivateHeaders/WebCore/AccessibilityObjectInterface.h:30,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/PrivateHeaders/WebCore/AccessibilityObject.h:32,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/PrivateHeaders/WebCore/AXObjectCache.h:30,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WebCore/PrivateHeaders/WebCore/ChromeClient.h:24,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:29,
                 from /home/mcatanzaro/Projects/WebKit/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:28,
                 from /home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-34.cpp:1:
/home/mcatanzaro/Projects/WebKit/WebKitBuild/GNOME-gtk3/WTF/Headers/wtf/text/WTFString.h:208:50: note: declared here
  208 |     WTF_EXPORT_PRIVATE String WARN_UNUSED_RETURN stripWhiteSpace() const;
      |                                                  ^~~~~~~~~~~~~~~

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220513/100a47f0/attachment-0001.htm>


More information about the webkit-unassigned mailing list