[Webkit-unassigned] [Bug 239350] Web Inspector: [Meta] Implement Timelines Film Strip

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=239350

--- Comment #24 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 459135
  --> https://bugs.webkit.org/attachment.cgi?id=459135
Patch v1.6

View in context: https://bugs.webkit.org/attachment.cgi?id=459135&action=review

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1307
>> +localizedStrings["Screenshots"] = "Screenshots";
> 
> why did this change from "Screen Shots"?  that matches what we do elsewhere in Web Inspector (and on macOS)

I've felt pretty neutral about "Screen Shots" vs "Screenshots", but this morning I did a search for occurrences of both in our code base. Quickly looking at our usage in Web Inspector, we actually only use "Screen Shot" in one place, for the name of screenshot file exported from Web Inspector. The other occurrences are both UI strings. "Capture Screenshot" and "Could not capture screenshot". (Existing function names throughout are styled as if it is a single word as well "screenshot" instead of "screenShot") We clearly lack true consistency due to these two different uses, but I'm tempted to say we should share the same stylization "screenshot" (one word) with the other UI strings, since the files we create end up existing outside of Web Inspector itself. I agree we should strive to be consistent, and in that spirit I'm now of the opinion we should match those exists strings that appear inside Web Inspector itself.

One other thing worth noting I discovered this morning while researching: While macOS names screenshot files "Screen Shot ...", the system-level help entry for this, built into the system, is titled "Take screenshots or screen recordings on Mac". If I had to reason a rule out of all this, it's that "screenshot" is the expected stylization, and files are named "Screen Shot ..." for presumably legacy purposes (compat with existing workflows, etc.).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220512/fb927150/attachment.htm>