[Webkit-unassigned] [Bug 240229] [GStreamer][VideoCapture] Add support for capturing encoded video streams from a webcam

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240229

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #459216|review?                     |review+, commit-queue+
              Flags|                            |

--- Comment #14 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 459216
  --> https://bugs.webkit.org/attachment.cgi?id=459216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459216&action=review

>>> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:71
>>> +    auto bin = makeGStreamerBin("capsfilter caps=\"video/x-raw\" name=mimetype-filter ! decodebin3 ! videoscale ! videoconvert ! videorate drop-only=1 average-period=1 name=videorate", false);
>> 
>> So passing true as second argument here wasn't working? Was it due to decodebin3?
> 
> Yes, this is because of decobin3.
> 
> As src pad is a "sometimes" pad the automatic ghost pad was connected to the videoscale right after and so the mimetype was correctly forced on the first capsfilter but it was useless as the bin src pad was bypassing it.

Ok then. Maybe later we could rework this part a bit, constructing the bin manually and handling db3 pads with the pad-added signal. But if this approach works fine let's land it :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220512/30e36faf/attachment-0001.htm>