[Webkit-unassigned] [Bug 240305] REGRESSION(r291038) [GTK][WPE] Fix build without remote inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 11 07:59:23 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=240305

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #459163|commit-queue+               |commit-queue-
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 459163
  --> https://bugs.webkit.org/attachment.cgi?id=459163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459163&action=review

> Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:126
>      parameters.inspectorServerAddress = Inspector::RemoteInspector::inspectorServerAddress();

Would be nice to define it conditionally, too, so it doesn't exist at all except when ENABLE(REMOTE_INSPECTOR) is defined. Just a bit more robust to future changes, in case leaving it uninitialized is not OK in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220511/9a93534e/attachment.htm>


More information about the webkit-unassigned mailing list