[Webkit-unassigned] [Bug 240297] New: [CMake][VS] PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated in incremental build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240297

            Bug ID: 240297
           Summary: [CMake][VS]
                    PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is
                    not updated in incremental build
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CMake
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com

[CMake][VS] PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated in incremental build

1. Build WinCairo with CMake Visual Studio generator
   perl Tools\Scripts\build-webkit --wincairo --debug --no-ninja

2. Edit builtins_generate_internals_wrapper_header.py to append a blank line

diff --git a/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_header.py b/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_header.py
index 8858460a0982..3faa59d20a70 100644
--- a/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_header.py
+++ b/Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_header.py
@@ -48,6 +48,7 @@ class BuiltinsInternalsWrapperHeaderGenerator(BuiltinsGenerator):

         sections = []
         sections.append(self.generate_license())
+        sections.append('')
         sections.append(Template(Templates.DoNotEditWarning).substitute(args))
         sections.append(Template(Templates.HeaderIncludeGuard).substitute(args))
         sections.append(self.generate_secondary_header_includes())

3. Incremental-build WinCairo
   perl Tools\Scripts\build-webkit --wincairo --debug --no-ninja

4. Check WebCoreJSBuiltinInternals.h files

$ ls -l WebKitBuild/Debug/WebCore/**/WebCoreJSBuiltinInternals.h
-rwxrwxrwx 1 fujii fujii 3541 May 11 15:12 WebKitBuild/Debug/WebCore/DerivedSources/WebCoreJSBuiltinInternals.h*
-rwxrwxrwx 1 fujii fujii 3537 May 11 14:30 WebKitBuild/Debug/WebCore/PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h*

PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220511/ca67b6c9/attachment.htm>