[Webkit-unassigned] [Bug 236710] [content-visibility] Add support for css content-visibility: hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236710

--- Comment #20 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 458860
  --> https://bugs.webkit.org/attachment.cgi?id=458860
Rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=458860&action=review

>> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-with-top-layer-003.tentative.html:14
>> +.hidden { ontent-visibility: hidden }
> 
> What is this change about?

I wanted to try something local at the time, but clearly this change is unwanted indeed. Thanks for pointing that one out! Note that the patch is not up for review for a reason though :)

>> Source/WebCore/dom/Element.cpp:3405
>> +        return;
> 
> This is kinda surprising to me, what bit of the spec says this?

I think this is https://drafts.csswg.org/css-contain/#content-visibility 4.3.11.

>> Source/WebCore/dom/Element.cpp:4820
>> +}
> 
> Not sure I'm understanding how this works? Is this trying to add/remove layers based on the node flag? 
> 
> I'm confused why the DOM side of the top layer logic should be touched here. Isn't this a layout feature?

I am back to work on this tomorrow, will have a look then, this code is from quite some time ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220510/c02e595b/attachment.htm>