[Webkit-unassigned] [Bug 240229] [GStreamer][VideoCapture] Add support for capturing encoded video streams from a webcam

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240229

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com

--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 459042
  --> https://bugs.webkit.org/attachment.cgi?id=459042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459042&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:158
> +        std::string mimeType;

We don't use std::string much here, we use String, AtomString, CString from WTF::. I wonder though could this one be const char*?

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:182
> +        selector.stopCondition.frameRate = static_cast<double>(numerator) / static_cast<double>(denominator);

gst_util_fraction_to_double()

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:198
> +            if (!gst_structure_get_int(structure, "width", &width)
> +                || !gst_structure_get_int(structure, "height", &height)
> +                || !gst_structure_get_fraction(structure, "framerate", &numerator, &denominator))

One line, you can go up to 120 chars per line.

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:201
> +            double frameRate = static_cast<double>(numerator) / static_cast<double>(denominator);

Ditto

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:204
> +            if ((width >= selector->stopCondition.width)
> +                && (height >= selector->stopCondition.height)
> +                && (frameRate >= selector->stopCondition.frameRate)) {

One line and no need for so many () I think?

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:211
> +            if ((width >= selector->maxWidth)
> +                && (height >= selector->maxHeight)
> +                && (frameRate >= selector->maxFrameRate)) {

Ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220510/4947aa0d/attachment-0001.htm>