[Webkit-unassigned] [Bug 240178] [macOS] Content filter blocking shield is not displayed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 6 15:02:25 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=240178

--- Comment #4 from Per Arne Vollan <pvollan at apple.com> ---
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 458966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458966&action=review
> 
> r=me
> 
> > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> > +        auto unblocked = false;
> > +        callOnMainThread([decisionHandler, unblocked] {
> > +            decisionHandler(unblocked);
> > +        });
> 
> Can unblocked be a local variable rather than a captured variable here?

Yes, that is a good point, will fix.

Thanks for reviewing!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220506/c33f8a16/attachment.htm>


More information about the webkit-unassigned mailing list