[Webkit-unassigned] [Bug 240175] WebKit has a broken module in Mac Catalyst

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240175

--- Comment #7 from Ian Anderson <iana at apple.com> ---
(In reply to Tim Horton from comment #3)
> Comment on attachment 458964 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458964&action=review
> 
> > Source/WebKit/Configurations/WebKit.xcconfig:35
> > +MODULEMAP_FILE = $(MODULEMAP_FILE_$(WK_COCOA_TOUCH)_$(WK_IS_CATALYST));
> > +MODULEMAP_FILE_cocoatouch_NO = Modules/iOS.modulemap;
> > +MODULEMAP_FILE_cocoatouch_YES = Modules/MacCatalyst.modulemap;
> > +MODULEMAP_FILE__NO = Modules/OSX.modulemap;
> 
> This is fine, though I think usually when we want to make this distinction
> we fall back to WK_PLATFORM_NAME instead (but, I admit, that would involve a
> lot more duplication).

Yeah, I couldn't decide which way was less gross. Let me know if you change your mind.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220506/eaa793a9/attachment.htm>