[Webkit-unassigned] [Bug 240175] WebKit has a broken module in Mac Catalyst

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=240175

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #458964|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 458964
  --> https://bugs.webkit.org/attachment.cgi?id=458964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458964&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:35
> +MODULEMAP_FILE = $(MODULEMAP_FILE_$(WK_COCOA_TOUCH)_$(WK_IS_CATALYST));
> +MODULEMAP_FILE_cocoatouch_NO = Modules/iOS.modulemap;
> +MODULEMAP_FILE_cocoatouch_YES = Modules/MacCatalyst.modulemap;
> +MODULEMAP_FILE__NO = Modules/OSX.modulemap;

This is fine, though I think usually when we want to make this distinction we fall back to WK_PLATFORM_NAME instead (but, I admit, that would involve a lot more duplication).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220506/d0b9a28b/attachment.htm>