[Webkit-unassigned] [Bug 239941] [WPE][Debug] http/tests/media/video-redirect.html crashing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 1 03:54:31 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=239941

--- Comment #1 from Philippe Normand <pnormand at igalia.com> ---
Not sure how to fix this properly, this might be a workaround...

diff --git a/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp b/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
index 49e80eeb6e40..63e8f3d4ad36 100644
--- a/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
+++ b/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
@@ -182,7 +182,7 @@ void TextureMapperLayer::paintSelf(TextureMapperPaintOptions& options)
         solidColorLayer.setColor(m_state.solidColor);
         contentsLayer = &solidColorLayer;
     }
-    if (!contentsLayer)
+    if (!contentsLayer || !contentsLayer->client())
         return;

     if (!m_state.contentsTileSize.isEmpty()) {
diff --git a/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h b/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h
index 12f56ab813ba..0d3c43578f96 100644
--- a/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h
+++ b/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h
@@ -45,9 +45,7 @@ public:
     }

     void setClient(TextureMapperPlatformLayer::Client* client) { m_client = client; }
-
-protected:
-    TextureMapperPlatformLayer::Client* client() { return m_client; }
+    TextureMapperPlatformLayer::Client* client() const { return m_client; }

 private:
     TextureMapperPlatformLayer::Client* m_client { nullptr };

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220501/1fa4fe8a/attachment.htm>


More information about the webkit-unassigned mailing list