[Webkit-unassigned] [Bug 238375] Add support for element.computedStyleMap()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238375

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #456208|review?                     |review+
              Flags|                            |

--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 456208
  --> https://bugs.webkit.org/attachment.cgi?id=456208
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456208&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.h:60
> +    enum class PropertyValueType { Resolved, Computed };

nit
: bool

> Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:67
> +ExceptionOr<Vector<RefPtr<CSSStyleValue>>> ComputedStylePropertyMapReadOnly::getAll(const String& property) const

This is mostly duplicate code.  Could you factor the shared logic into a helper function?

> Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:102
> +Vector<StylePropertyMapReadOnly::StylePropertyMapEntry> ComputedStylePropertyMapReadOnly::entries() const

Could you add a few spec links in this file?  There is some interesting logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220401/78a967ee/attachment.htm>