[Webkit-unassigned] [Bug 238494] REGRESSION(r290360): [GLX] Crash on process exit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238494

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #456099|review?                     |review+
              Flags|                            |

--- Comment #12 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 456099
  --> https://bugs.webkit.org/attachment.cgi?id=456099
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456099&action=review

> Source/WebCore/ChangeLog:13
> +        PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constrcutor to

constructor

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:77
> +    // In X11 only one PlatformDisplay instance is allowed per process which is the sharedDisplay one.

Is there an assert for this already? I'd like to see an assert to enforce this, or else at least ensure the exit handler is registered called only once.

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:82
> +    std::atexit([] {
> +	PlatformDisplay::sharedDisplay().clearSharingGLContext();

Indentation is wrong:

ERROR: Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:82:  Tab found; better to use spaces  [whitespace/tab] [1]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220330/baf1ac2a/attachment-0001.htm>