[Webkit-unassigned] [Bug 233785] [GTK4] WebKitWebView::context-menu errors out on GTK4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233785

--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Alexander Mikhaylenko from comment #5)
> This one is tricky - since it differs between GTK3 and GTK4, we have to
> split the signal and the vfunc between gtk3 and gtk4 somehow... This likely
> involves reorganizing WebKitWebView.c/h completely.

It shouldn't require a huge reorg. Remember that we are first waiting for gi-docgen support to land. Then we can move the doc comments that need to differ between GTK3/GTK4/WPE out into separate files, while leaving the code in one place. With this plan, #if won't work for the doc comments, but it will work for the code. You can just leave a non-doc comment where the doc comment would normally be, pointing to the file that holds the real doc comments.

...right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220329/a26673a5/attachment.htm>