[Webkit-unassigned] [Bug 238368] Some Apple internal clients fail to build due to redeclared AppKit types in WebKitLegacy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238368

--- Comment #9 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 455831
  --> https://bugs.webkit.org/attachment.cgi?id=455831
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455831&action=review

> Source/WebKitLegacy/mac/Misc/WebDownload.h:87
> +#if TARGET_OS_IPHONE
> +- (WAKWindow *)downloadWindowForAuthenticationSheet:(WebDownload *)download;
> +#else
>  - (NSWindow *)downloadWindowForAuthenticationSheet:(WebDownload *)download;
> +#endif

I'm surprised this change was needed as this appears at the top of the header file:

#if TARGET_OS_IPHONE
#import <WebKitLegacy/WAKAppKitStubs.h>
#endif

Did you do a search and replace when looking for AppKit types to update in WebKitLegacy headers?

Note that it is not necessary to fix this before landing this patch, but I think including that header is the canonical way this has been solved in the past.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220328/c617f271/attachment.htm>