[Webkit-unassigned] [Bug 235027] [JSC][ARMv7] Cleanup GPR numbering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235027

--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 455900
  --> https://bugs.webkit.org/attachment.cgi?id=455900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455900&action=review

Ah, I think we have some problems.

> Source/JavaScriptCore/jit/GPRInfo.h:569
> +    static constexpr GPRReg regT4 = ARMRegisters::r4;

regT4 is r4, then LLInt t4 must be r4.

> Source/JavaScriptCore/llint/LLIntData.h:398
> +#if CPU(ARM_THUMB2)
> +    static constexpr GPRReg pcGPR = ARMRegisters::r8;
> +#else
>      static constexpr GPRReg pcGPR = GPRInfo::regT4;
> +#endif

We should use regT4 in all architectures.

> Source/JavaScriptCore/offlineasm/arm.rb:40
> +#  x8 => t4                 (callee-save, PC)

But it seems that t5 is r8. Is it correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220328/56edf8d4/attachment.htm>