[Webkit-unassigned] [Bug 235027] [JSC][ARMv7] Cleanup GPR numbering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235027

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #455632|review?                     |review+
              Flags|                            |

--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 455632
  --> https://bugs.webkit.org/attachment.cgi?id=455632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455632&action=review

r=me with comments.

> Source/JavaScriptCore/jit/BaselineJITRegisters.h:95
> +    constexpr GPRReg globalObjectGPR = preferredArgumentGPR<SlowOperation, 0>();
> +    constexpr JSValueRegs thrownValueJSR = preferredArgumentJSR<SlowOperation, 1>();
> +    constexpr GPRReg bytecodeOffsetGPR = GPRInfo::nonArgGPR0;

This change is not necessary.

> Source/JavaScriptCore/llint/LLIntData.h:394
> +#if CPU(ARM)

Use CPU(ARM_THUMB2)

> Source/JavaScriptCore/llint/LLIntData.h:-405
> -#elif CPU(MIPS) || CPU(ARM_THUMB2)

Use CPU(ARM_THUMB2)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220326/41b8ee05/attachment.htm>