[Webkit-unassigned] [Bug 238368] Some Apple internal clients fail to build due to redeclared AppKit types in WebKitLegacy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 23:02:42 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=238368

--- Comment #6 from Ian Anderson <iana at apple.com> ---
Comment on attachment 455742
  --> https://bugs.webkit.org/attachment.cgi?id=455742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455742&action=review

>> Source/WebKitLegacy/mac/Misc/WebNSViewExtras.h:48
>> +#endif
> 
> Would be slightly better to reverse the logic here and use `#if TARGET_OS_IPHONE/#else/#endif` instead.

Sure. I was kind of trying to match the files that had other !TARGET_OS_IPHONE in them, but I prefer it your way too!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220326/b8017e85/attachment.htm>


More information about the webkit-unassigned mailing list