[Webkit-unassigned] [Bug 238375] Add support for element.computedStyleMap()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238375

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #455763|commit-queue-               |
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 455763
  --> https://bugs.webkit.org/attachment.cgi?id=455763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455763&action=review

This looks fine to me, save for a couple of small comments; but I would
rather have someone more familiar with the CSS/WebIDL machinery to give
the final r+ :)

View in context: https://bugs.webkit.org/attachment.cgi?id=455763&action=review

> Source/WebCore/dom/ElementRareData.h:151
> +        if (m_m_computedStyleMap)

Typo, double “m_” prefix: m_m_computedStyleMap → m_computedStyleMap

> Source/WebCore/dom/StyledElement.cpp:102
> +        // FIXME: implement.

Wouldn't it be better to call the notImplemented() helper function here instead
of using a comment?

> Source/WebCore/dom/ElementRareData.h:151
> +        if (m_m_computedStyleMap)

Typo, double “m_” prefix: m_m_computedStyleMap → m_computedStyleMap

> Source/WebCore/dom/StyledElement.cpp:102
> +        // FIXME: implement.

Wouldn't it be better to call the notImplemented() helper function here instead
of using a comment?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220325/c5f469d2/attachment-0001.htm>