[Webkit-unassigned] [Bug 238356] New: [css-cascade] "related-property" logic for (-webkit-)text-orientation is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238356

            Bug ID: 238356
           Summary: [css-cascade] "related-property" logic for
                    (-webkit-)text-orientation is broken
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: obrufau at igalia.com

Created attachment 455703

  --> https://bugs.webkit.org/attachment.cgi?id=455703&action=review

testcase

The text-orientation and -webkit-text-orientation properties are defined with the "related-property" flag.
They are two different longhands that share a computed value, so this flag tries to address the case where both properties are specified.
Typically, properties are applied in alphabetical order within their priority group, but "related-property" achieves that the last specified one wins:

  <div style="-webkit-text-orientation: mixed; text-orientation: upright">I'm upright</div>
  <div style="text-orientation: mixed; -webkit-text-orientation: upright">I'm upright</div>

However, it doesn't work here (see attached testcase):

  <style>
  div { -webkit-text-orientation: mixed }
  div { text-orientation: upright }
  </style>
  <div>I should be upright</div>

This case works well for (-webkit-)box-shadow, which instead of "related-property" is handled by shouldApplyPropertyInParseOrder().

I thought I could handle (-webkit-)text-orientation in the same way (bug 238350), but when shouldApplyPropertyInParseOrder() returns true, the property is deferred and applied after low-priority properties.
This conflicts with (-webkit-)text-orientation, which need to be high priority.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220324/41b78ffb/attachment.htm>