[Webkit-unassigned] [Bug 238291] [WebAssembly][Modules] Support Wasm module import from a JS Worker module
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 23 18:47:24 PDT 2022
https://bugs.webkit.org/show_bug.cgi?id=238291
Yusuke Suzuki <ysuzuki at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ysuzuki at apple.com
--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 455591
--> https://bugs.webkit.org/attachment.cgi?id=455591
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=455591&action=review
The patch overall looks great! Some comments.
> Source/WebCore/ChangeLog:16
> + Instead of ignoring all other tasks, the internal timer task and
> + tasks used for WorkerEventLoop are allowed in order to allow
> + JS VM microtasks to be queued and run.
Could you explain a bit more detail about this?
1. What problem happens (in which code)
2. Why does it happen?
3. What is the solution to that?
> Source/WebCore/workers/WorkerEventLoop.cpp:77
> +const String WorkerEventLoop::taskMode()
`const` is not necessary as it is copying value.
> Source/WebCore/workers/WorkerRunLoop.cpp:75
> + const String mode() const
Return `const String&`.
> Source/WebCore/workers/WorkerRunLoop.cpp:174
> + JSC::JSRunLoopTimer::TimerNotificationCallback timerAddedTask = createSharedTask<JSC::JSRunLoopTimer::TimerNotificationType>([this, predicateMode] {
Let's pass via WTFMove(predicateMode) instead of copying.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220324/8e49903a/attachment-0001.htm>
More information about the webkit-unassigned
mailing list