[Webkit-unassigned] [Bug 238018] [JSC] Add DoNotHaveTagRegisters mode to unboxDouble

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238018

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #454950|review?                     |review+
              Flags|                            |

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 454950
  --> https://bugs.webkit.org/attachment.cgi?id=454950
v1

View in context: https://bugs.webkit.org/attachment.cgi?id=454950&action=review

r=me with comment.

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1386
> +            GPRReg scratch = scratchRegister();
> +            move(TrustedImm64(JSValue::NumberTag), scratch);
> +            add64(scratch, gpr, resultGPR);

I think we should not use scratchRegister() in AssemblyHelpers if possible.
Can you instead add,

void MacroAssembler::add64(TrustedImm64, GPRReg, GPRReg)

function and use it instead here? And inside add64, we can use scratchRegister.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220322/fd12fb38/attachment-0001.htm>