[Webkit-unassigned] [Bug 237112] [XCBuild] libwebrtc's headers are copied via rsync and do not emit task outputs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 15:08:33 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=237112

--- Comment #16 from Elliott Williams <emw at apple.com> ---
My understanding of the problem is that libwebrtc has many quote-style includes of absl headers. This is fine when webrtc *itself* is building, because it puts absl on its HEADER_SEARCH_PATHS, but it's a problem for *other* project which import webrtc through a bracket-style include.

This causes WebCore to fail with an include trace like:

    In file included from Sources/WebKit/Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:32:
    In file included from Sources/WebKit/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:44:
    In file included from SDKs/iPhoneOS16.0.Internal.sdk/usr/local/include/webrtc/api/peer_connection_interface.h:79:
    /usr/local/include/absl/types/optional.h:39:10: fatal error: 'absl/utility/utility.h' file not found

…because it doesn't have /usr/local/include on its include search path, only its *library* search path.

As I understand it, this is really just a disagreement between the two projects as to how we differentiate between "project" and "library" headers. The right move is probably to add /usr/local/include to WebCore's HEADER_SEARCH_PATHS, or to add absl headers back to the `libwebrtc` target, so that Xcode puts them into the appropriate header map.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220315/08d0d350/attachment.htm>


More information about the webkit-unassigned mailing list