[Webkit-unassigned] [Bug 237816] REGRESSION(r286955): Rendering Links during search: highlighting fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 04:51:42 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=237816

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com,
                   |                            |ntim at apple.com,
                   |                            |simon.fraser at apple.com
          Component|WebKitGTK                   |CSS
            Summary|[GTK] Rendering Links       |REGRESSION(r286955):
                   |during search: highlighting |Rendering Links during
                   |fails                       |search: highlighting fails

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
This is not GTK specific, but it's more noticeable because we use white color for the selection text foreground. This regressed in r286955, because in case of text with decorations, the foreground text is rendered in the same coalesced marked text loop than the decorations and StyledMarkedText::coalesceAdjacentWithEqualDecorations() doesn't take into account the text styles. So, when we start rendering from the beginning of the line, only one style marked text is generated and the whole line is painted with the selection style (white foreground), on white background it looks like the non selected text disappears. When we start selecting from the end of the line, a single styled marked text is generated, but the selected text is painted with the non-selected style, and it becomes white once we complete the line selection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220315/a9e82753/attachment-0001.htm>


More information about the webkit-unassigned mailing list