[Webkit-unassigned] [Bug 237717] [macOS] Image decoders should be restricted for Mail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237717

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #454398|                            |review+
              Flags|                            |

--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 454398
  --> https://bugs.webkit.org/attachment.cgi?id=454398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454398&action=review

r=me

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:78
> +    static bool m_enableRestrictedDecoding;

For static variables, we use the "s_" prefix. "m_" for "member", "s_" for "static".

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:450
> +        if (auto trustdExtensionHandle = SandboxExtension::createHandleForMachLookup("com.apple.trustd.agent"_s, std::nullopt))
> +            parameters.trustdExtensionHandle = WTFMove(*trustdExtensionHandle);

In a follow-up, it would be nice to disconnect Mail from trustd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220310/dec1c922/attachment-0001.htm>