[Webkit-unassigned] [Bug 237601] [GTK][WPE] Web Inspector: make it possible to use the remote inspector from other browsers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237601

--- Comment #11 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 454232
  --> https://bugs.webkit.org/attachment.cgi?id=454232
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=454232&action=review

WebInspectorUI changes look fine to me - but please make sure to add a license header as joepeck mentioned.

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:188
> +my $shouldIncludeInspectorFrontendHost = defined $ENV{'INCLUDE_INSPECTOR_FRONTEND_HOST'} && ($ENV{'INCLUDE_INSPECTOR_FRONTEND_HOST'} eq 'YES');

Nit: Can we call this `$shouldIncludeBrowserInspectorFrontendHost` so its clearer what the setting actually does/relates to?

> Source/WebInspectorUI/UserInterface/Base/BrowserInspectorFrontendHost.js:213
> +            // FIXME: Create a Blob from the content, get an object URL, open it to trigger a download.

Should this throw an exception since call sites should be checking if `canSave` is true first anyways?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220309/57781671/attachment.htm>