[Webkit-unassigned] [Bug 237601] [GTK][WPE] Web Inspector: make it possible to use the remote inspector from other browsers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237601

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 454114
  --> https://bugs.webkit.org/attachment.cgi?id=454114
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454114&action=review

>> Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:78
>> +        g_setenv("WEBKIT_INSPECTOR_SERVER", inspectorAddress.get(), TRUE);
> 
> Careful: this function is called inside std::call_once, which uses threads, so it's too late to modify the environment.
> 
> IMO you are insufficiently fearful of setenv. It's not just a theoretical problem: remember we have documented cases where this broke gnome-session (https://bugzilla.gnome.org/show_bug.cgi?id=754951) and also gnome-initial-setup (downstream fork).

You are right, it shouldn't be a problem after https://bugs.webkit.org/show_bug.cgi?id=237646

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220309/b0e7efb6/attachment.htm>