[Webkit-unassigned] [Bug 237527] [GTK][WPE] Add initial adwaita style for PDF.js

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 00:39:39 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=237527

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 453972
  --> https://bugs.webkit.org/attachment.cgi?id=453972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review

>> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27
>> +}
> 
> Is the file chooser not working?

Yes, opening files results in an error message. I don't know why, but I'm not sure we want to provide that functionality either.

>> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31
>> +}
> 
> Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure.

This is not hiding anything, this is telling WebKit not to use the native appearance for the zoom combo box in the toolbar, because the adwaita one is bigger and doesn't look right. Hopefully Alexander can add customizations here to make it look great and consistent with adwaita.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220308/b429a523/attachment.htm>


More information about the webkit-unassigned mailing list