[Webkit-unassigned] [Bug 237516] PDF.js content script is adding custom cocoa style unconditionally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237516

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 453953
  --> https://bugs.webkit.org/attachment.cgi?id=453953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453953&action=review

>> Source/WebCore/html/PDFDocument.cpp:217
>> +#endif
> 
> Do #if preprocessing conditions not work in the JS file? If they do, I'd rather see this logic in the JS file.

I don't think so, the script is injected as is, without any preprocessing. I don't know how to make it platform dependent in a JS file, that's why I moved it to cpp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220308/366aef5c/attachment.htm>