[Webkit-unassigned] [Bug 235736] Expose some web APIs on Shadow Realms and Worklets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235736

Caitlin Potter (:caitp) <caitp at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caitp at igalia.com

--- Comment #8 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 453426
  --> https://bugs.webkit.org/attachment.cgi?id=453426
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453426&action=review

It's hard to argue with the improvements in the WPT results --- LGTM

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1975
> +            return $contextExposures eq "*";

Personally, I'd be happy if there was a comment here like the one in the ChangeLog explaining why this is needed, so future readers don't need to find the ChangeLog entry to understand it. It isn't entirely intuitive, IMHO.

> Also required adjustment to CodeGeneratorJS.pm since it refused to
> generate a runtime check when a member is exposed less than the interface it
> appears on *and* in more than one scope.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220307/d9e6dfdb/attachment.htm>