[Webkit-unassigned] [Bug 237516] PDF.js content script is adding custom cocoa style unconditionally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237516

Tim Nguyen (:ntim) <ntim at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ntim at apple.com
 Attachment #453953|review?                     |review+
              Flags|                            |

--- Comment #2 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 453953
  --> https://bugs.webkit.org/attachment.cgi?id=453953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453953&action=review

> Source/WebCore/html/PDFDocument.cpp:217
> +#if PLATFORM(COCOA)
> +    link->setAttribute(hrefAttr, "webkit-pdfjs-viewer://pdfjs/extras/cocoa/style.css"_s);
> +#endif

Do #if preprocessing conditions not work in the JS file? If they do, I'd rather see this logic in the JS file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220307/645d729d/attachment.htm>